GustavoandClaude Sonnet 5
124516e64a
Root cause found for why the real Slack message showed "→ Validar e
executar" for nearly every ACTIONABLE_NOW ticket: logic/message.js's
ACTION_LABELS map had a hardcoded entry for ACTIONABLE_NOW that always
won over the AI's actual next_action field in shortActionLabel(). The
AI's real, specific, already-validated-as-non-generic next_action (e.g.
"Realizar inventário das máquinas") was being silently discarded for
display purposes on every single message. Fixed by removing the
ACTIONABLE_NOW entry -- it now falls through to the existing
next_action-based fallback (already there, just unreachable for that
class before). UNASSIGNED_ACTIONABLE intentionally keeps its fixed
"Atribuir técnico" label -- that IS the correct display for that class.
logic/classification.js: expanded GENERIC_NEXT_ACTION_PHRASES with the
exact phrase that leaked through ("validar e executar") plus the
mission's additional list (validar chamado, prosseguir atendimento,
executar chamado, tratar chamado, analisar chamado). Bumped
AI_CLASSIFIER_VERSION 3->4 since this changes what next_action values
validate as non-generic -- forces reclassification of any cached
candidate that only passed under the older, narrower blacklist.
n8n/nodes/validate-ai-response.node.js: generic-next-action rejections
now get their own distinct fallback_reason ('generic_or_unsupported_
next_action') instead of being lumped into 'invalid_json', matching the
same pattern already used for the technician-vendor conflict.
logic/slack.js + logic/config.js: added FORCE_SEND (default false).
Manual-triggered runs now never send for real even with SEND_ENABLED=
true in production, unless FORCE_SEND is also explicitly set -- protects
against someone clicking "Execute Workflow" in production and
accidentally re-sending today's digest.
Added format-safety regression tests (no literal backslash-n, URL never
bleeds into the next item's id, no markdown-wrapped URLs) -- verified
these were never actually triggered in a real send (the reported
corruption was n8n's raw JSON data-inspector view, not a delivered
Slack message; both manual runs in question had shouldSend:false).
169/169 tests passing.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
101 lines
5.5 KiB
JavaScript
101 lines
5.5 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const {
|
|
computeMessageHash, shouldSendByConfig, alreadySentSuccessfully, evaluateSendGuard, buildEnvioDigestRecord,
|
|
} = require('./slack');
|
|
|
|
test('computeMessageHash e deterministico para o mesmo texto', () => {
|
|
assert.equal(computeMessageHash('ola mundo'), computeMessageHash('ola mundo'));
|
|
});
|
|
|
|
test('computeMessageHash muda quando o texto muda', () => {
|
|
assert.notEqual(computeMessageHash('ola mundo'), computeMessageHash('ola mundo!'));
|
|
});
|
|
|
|
test('SEND_ENABLED=false nunca deixa enviar -- missao secao 22/13', () => {
|
|
assert.equal(shouldSendByConfig({ sendEnabled: false }), false);
|
|
});
|
|
|
|
test('SEND_ENABLED=true libera o envio (sujeito ainda a idempotencia)', () => {
|
|
assert.equal(shouldSendByConfig({ sendEnabled: true }), true);
|
|
});
|
|
|
|
test('alreadySentSuccessfully detecta envio de sucesso identico (mesma data/tipo/hash)', () => {
|
|
const existing = [{ report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'abc', status: 'success' }];
|
|
assert.equal(alreadySentSuccessfully(existing, { reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' }), true);
|
|
});
|
|
|
|
test('alreadySentSuccessfully ignora registros de falha -- retry apos erro nao fica bloqueado', () => {
|
|
const existing = [{ report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'abc', status: 'failed' }];
|
|
assert.equal(alreadySentSuccessfully(existing, { reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' }), false);
|
|
});
|
|
|
|
test('alreadySentSuccessfully ignora envios de outro dia ou outro hash', () => {
|
|
const existing = [{ report_date: '2026-08-24', run_type: 'scheduled', message_hash: 'abc', status: 'success' }];
|
|
assert.equal(alreadySentSuccessfully(existing, { reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' }), false);
|
|
const existing2 = [{ report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'xyz', status: 'success' }];
|
|
assert.equal(alreadySentSuccessfully(existing2, { reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' }), false);
|
|
});
|
|
|
|
test('evaluateSendGuard: Slack NAO envia com SEND_ENABLED=false -- teste obrigatorio #13', () => {
|
|
const result = evaluateSendGuard({ config: { sendEnabled: false }, existingRecords: [], reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' });
|
|
assert.equal(result.shouldSend, false);
|
|
assert.equal(result.reason, 'send_disabled');
|
|
});
|
|
|
|
test('evaluateSendGuard: Slack envia com SEND_ENABLED=true e nenhum envio anterior -- teste obrigatorio #14', () => {
|
|
const result = evaluateSendGuard({ config: { sendEnabled: true }, existingRecords: [], reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' });
|
|
assert.equal(result.shouldSend, true);
|
|
assert.equal(result.reason, 'ok');
|
|
});
|
|
|
|
test('evaluateSendGuard: envio duplicado e bloqueado -- teste obrigatorio #15', () => {
|
|
const existing = [{ report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'abc', status: 'success' }];
|
|
const result = evaluateSendGuard({ config: { sendEnabled: true }, existingRecords: existing, reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' });
|
|
assert.equal(result.shouldSend, false);
|
|
assert.equal(result.reason, 'already_sent');
|
|
});
|
|
|
|
test('runType manual NAO envia mesmo com SEND_ENABLED=true, a menos que FORCE_SEND tambem esteja ligado -- missao "correcao final" secao 16', () => {
|
|
const result = evaluateSendGuard({
|
|
config: { sendEnabled: true, forceSend: false }, existingRecords: [], reportDate: '2026-08-25', runType: 'manual', messageHash: 'abc',
|
|
});
|
|
assert.equal(result.shouldSend, false);
|
|
assert.equal(result.reason, 'manual_run_needs_force_send');
|
|
});
|
|
|
|
test('runType manual envia quando FORCE_SEND esta explicitamente ligado -- missao "correcao final" secao 17', () => {
|
|
const result = evaluateSendGuard({
|
|
config: { sendEnabled: true, forceSend: true }, existingRecords: [], reportDate: '2026-08-25', runType: 'manual', messageHash: 'abc',
|
|
});
|
|
assert.equal(result.shouldSend, true);
|
|
});
|
|
|
|
test('runType scheduled envia normalmente com SEND_ENABLED=true, independente de FORCE_SEND', () => {
|
|
const result = evaluateSendGuard({
|
|
config: { sendEnabled: true, forceSend: false }, existingRecords: [], reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc',
|
|
});
|
|
assert.equal(result.shouldSend, true);
|
|
});
|
|
|
|
test('evaluateSendGuard: retry (mensagem diferente) apos falha anterior nao e bloqueado', () => {
|
|
const existing = [{ report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'abc', status: 'failed' }];
|
|
const result = evaluateSendGuard({ config: { sendEnabled: true }, existingRecords: existing, reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc' });
|
|
assert.equal(result.shouldSend, true);
|
|
});
|
|
|
|
test('buildEnvioDigestRecord monta o registro de sucesso corretamente', () => {
|
|
const record = buildEnvioDigestRecord({ reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc', sentAt: 12345, status: 'success' });
|
|
assert.deepEqual(record, {
|
|
report_date: '2026-08-25', run_type: 'scheduled', message_hash: 'abc', sent_at: 12345, status: 'success', error_detail: null,
|
|
});
|
|
});
|
|
|
|
test('buildEnvioDigestRecord monta o registro de falha com error_detail -- falha nunca registra sucesso (teste obrigatorio #16)', () => {
|
|
const record = buildEnvioDigestRecord({
|
|
reportDate: '2026-08-25', runType: 'scheduled', messageHash: 'abc', sentAt: 12345, status: 'failed', errorDetail: 'HTTP 500',
|
|
});
|
|
assert.equal(record.status, 'failed');
|
|
assert.equal(record.error_detail, 'HTTP 500');
|
|
});
|