GustavoandClaude Sonnet 5
124516e64a
Root cause found for why the real Slack message showed "→ Validar e
executar" for nearly every ACTIONABLE_NOW ticket: logic/message.js's
ACTION_LABELS map had a hardcoded entry for ACTIONABLE_NOW that always
won over the AI's actual next_action field in shortActionLabel(). The
AI's real, specific, already-validated-as-non-generic next_action (e.g.
"Realizar inventário das máquinas") was being silently discarded for
display purposes on every single message. Fixed by removing the
ACTIONABLE_NOW entry -- it now falls through to the existing
next_action-based fallback (already there, just unreachable for that
class before). UNASSIGNED_ACTIONABLE intentionally keeps its fixed
"Atribuir técnico" label -- that IS the correct display for that class.
logic/classification.js: expanded GENERIC_NEXT_ACTION_PHRASES with the
exact phrase that leaked through ("validar e executar") plus the
mission's additional list (validar chamado, prosseguir atendimento,
executar chamado, tratar chamado, analisar chamado). Bumped
AI_CLASSIFIER_VERSION 3->4 since this changes what next_action values
validate as non-generic -- forces reclassification of any cached
candidate that only passed under the older, narrower blacklist.
n8n/nodes/validate-ai-response.node.js: generic-next-action rejections
now get their own distinct fallback_reason ('generic_or_unsupported_
next_action') instead of being lumped into 'invalid_json', matching the
same pattern already used for the technician-vendor conflict.
logic/slack.js + logic/config.js: added FORCE_SEND (default false).
Manual-triggered runs now never send for real even with SEND_ENABLED=
true in production, unless FORCE_SEND is also explicitly set -- protects
against someone clicking "Execute Workflow" in production and
accidentally re-sending today's digest.
Added format-safety regression tests (no literal backslash-n, URL never
bleeds into the next item's id, no markdown-wrapped URLs) -- verified
these were never actually triggered in a real send (the reported
corruption was n8n's raw JSON data-inspector view, not a delivered
Slack message; both manual runs in question had shouldSend:false).
169/169 tests passing.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
45 lines
2.1 KiB
JavaScript
45 lines
2.1 KiB
JavaScript
function toBool(value, defaultValue) {
|
|
if (value === undefined || value === null || value === '') return defaultValue;
|
|
return String(value).toLowerCase() !== 'false';
|
|
}
|
|
|
|
function toNumber(value, defaultValue) {
|
|
const n = Number(value);
|
|
return Number.isFinite(n) ? n : defaultValue;
|
|
}
|
|
|
|
function parseConfig(env) {
|
|
const e = env || {};
|
|
return {
|
|
aiEnabled: toBool(e.AI_ENABLED, true),
|
|
aiProvider: e.AI_PROVIDER || 'openai',
|
|
aiModel: e.AI_MODEL || 'gpt-4o-mini',
|
|
candidatePoolSize: toNumber(e.CANDIDATE_POOL_SIZE, 60),
|
|
// Igual a candidatePoolSize por padrao -- nenhum candidato elegivel deve ficar sem
|
|
// analise semantica por um cap artificial (missao "finalizacao para producao", secao
|
|
// 13). AI_FALLBACK fica reservado para falha real de provider/timeout, nao para
|
|
// economia de chamadas dentro de um pool que o cache ja deixou barato de repetir.
|
|
aiMaxCandidates: toNumber(e.AI_MAX_CANDIDATES, 60),
|
|
topN: Math.min(toNumber(e.TOP_N, 10), 10),
|
|
cooldownDays: toNumber(e.COOLDOWN_DAYS, 1),
|
|
aiConfidenceThreshold: toNumber(e.AI_CONFIDENCE_THRESHOLD, 0.6),
|
|
aiMaxContextChars: toNumber(e.AI_MAX_CONTEXT_CHARS, 4000),
|
|
devMode: toBool(e.DEV_MODE, true),
|
|
shadowMode: toBool(e.SHADOW_MODE, true),
|
|
diasSemInteracaoAlerta: toNumber(e.DIAS_SEM_INTERACAO_ALERTA, 2),
|
|
horasSlaRisco: toNumber(e.HORAS_SLA_RISCO, 8),
|
|
// Gate explicito de envio real -- nunca depende de editar codigo pra habilitar/desabilitar
|
|
// (missao "finalizacao para producao", secao 22). Default false: so quem liga
|
|
// explicitamente no Config node manda mensagem de verdade.
|
|
environment: e.ENVIRONMENT || 'dev',
|
|
sendEnabled: toBool(e.SEND_ENABLED, false),
|
|
// So importa pra execucoes 'manual' -- protege contra alguem clicar "Execute Workflow" em
|
|
// producao (SEND_ENABLED=true) e mandar o digest de novo sem querer. Runs agendadas nunca
|
|
// olham esse campo. Default false: manual nunca envia de verdade sem override explicito
|
|
// (missao "correcao final", secao 16/17).
|
|
forceSend: toBool(e.FORCE_SEND, false),
|
|
};
|
|
}
|
|
|
|
module.exports = { parseConfig, toBool, toNumber };
|