Production-readiness cycle. Classifier was excessively conservative (real Run A: ACTIONABLE_NOW/UNASSIGNED_ACTIONABLE both 0) and made concrete semantic mistakes on real tickets: - #34419: technician "Rafael Brito" (internal) classified as WAITING_VENDOR waiting_for -- an internal technician is not a vendor. - #37389: ticket had concrete open tasks ("Realizar um inventário das máquinas", "Alinhar o dia...") but was classified INSUFFICIENT_CONTEXT. - Generic next_action ("Revisar chamado") repeated across unrelated tickets, proving nothing about real actionability. Rewrote the system prompt (n8n/nodes/prepare-ai-prompt.node.js) with: practical actionability definition ("suporte consegue fazer algo util agora", explicit inclusion list); contatar-vs-aguardar distinction with examples; WAITING_* requires positive evidence (action already taken AND external dependency still open); technician-vs-vendor distinction citing the TECNICO context field; STATUS Planejado alone != blocked/scheduled; SCHEDULED requires an explicit date/window; mandatory chronological interpretation (most recent apontamento wins over a superseded old blocker); next_action must be concrete, with explicit accepted/rejected examples; INSUFFICIENT_CONTEXT bar raised (ask "is there a diagnostic step available even without full info" first). n8n/nodes/prepare-ai-prompt.node.test.js: 10 new tests asserting each rule's text is still present in the prompt (deterministic proxy -- behavioral proof comes from the real DEV run, inspected manually). logic/classification.js: added AI_CLASSIFIER_VERSION=3 (stamped on every valid classification); added a deterministic safety net (not just a prompt hope) -- isWaitingForInternalTechnician() rejects WAITING_VENDOR when waiting_for matches the ticket's own TECNICO field, routing to a new fallback_reason 'ai_semantic_conflict' instead of accepting a known-wrong semantic classification; added next_action genericness rejection (isGenericNextAction) for ACTIONABLE_NOW/UNASSIGNED_ACTIONABLE only. n8n/nodes/validate-ai-response.node.js: now passes the ticket into validateAiClassification() so the technician guard has the facts it needs. logic/cache.js: added buildCacheKey(contextHash, classifierVersion) -> "<hash>:v<version>", stored in the same last_context_hash column (no schema migration) -- bumping AI_CLASSIFIER_VERSION now forces a cache miss on every ticket without manually clearing the Data Table. n8n/nodes/decide-needs-ai.node.js / prepare-memoria-analise-record.node.js updated to compute/persist the composite key. logic/config.js: AI_MAX_CANDIDATES default raised 30->60 (now equals CANDIDATE_POOL_SIZE) -- no candidate should go unanalyzed by an artificial cap now that Run B already proved the cache makes repeat runs cheap; AI_FALLBACK stays reserved for real provider failures. Also added SEND_ENABLED (default false) and ENVIRONMENT config fields for the real Slack send gate (used by logic/slack.js, next commit). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
136 lines
5.9 KiB
JavaScript
136 lines
5.9 KiB
JavaScript
const { test } = require('node:test');
|
|
const assert = require('node:assert/strict');
|
|
const { validateAiClassification, VALID_CLASSIFICATIONS, AI_CLASSIFIER_VERSION } = require('./classification');
|
|
|
|
function validRaw(overrides) {
|
|
return Object.assign({
|
|
classification: 'ACTIONABLE_NOW',
|
|
actionable_today: true,
|
|
confidence: 0.91,
|
|
blocker_type: null,
|
|
waiting_for: null,
|
|
next_action: 'Validar equipamento e registrar resultado.',
|
|
suggested_action_type: 'technical_action',
|
|
business_risk: 'medium',
|
|
reason: 'Existe acao tecnica pendente.',
|
|
evidence: ['ultimo apontamento indica necessidade de validacao'],
|
|
}, overrides);
|
|
}
|
|
|
|
test('objeto valido passa e normaliza campos', () => {
|
|
const result = validateAiClassification(validRaw({}));
|
|
assert.equal(result.valid, true);
|
|
assert.equal(result.data.classification, 'ACTIONABLE_NOW');
|
|
assert.equal(result.data.is_fallback, false);
|
|
});
|
|
|
|
test('classification invalida falha com erro claro', () => {
|
|
const result = validateAiClassification(validRaw({ classification: 'ALGO_INVENTADO' }));
|
|
assert.equal(result.valid, false);
|
|
assert.ok(result.errors.some((e) => e.includes('classification')));
|
|
});
|
|
|
|
test('JSON invalido/null nao lanca excecao', () => {
|
|
assert.doesNotThrow(() => validateAiClassification(null));
|
|
assert.doesNotThrow(() => validateAiClassification('nao e objeto'));
|
|
assert.equal(validateAiClassification(null).valid, false);
|
|
});
|
|
|
|
test('next_action vazia ou so espacos falha (nao vazia e requisito minimo de qualidade)', () => {
|
|
assert.equal(validateAiClassification(validRaw({ next_action: '' })).valid, false);
|
|
assert.equal(validateAiClassification(validRaw({ next_action: ' ' })).valid, false);
|
|
});
|
|
|
|
test('confidence fora de 0..1 falha', () => {
|
|
const result = validateAiClassification(validRaw({ confidence: 1.5 }));
|
|
assert.equal(result.valid, false);
|
|
});
|
|
|
|
test('evidence e limitado a 5 itens', () => {
|
|
const result = validateAiClassification(validRaw({ evidence: ['a', 'b', 'c', 'd', 'e', 'f', 'g'] }));
|
|
assert.equal(result.data.evidence.length, 5);
|
|
});
|
|
|
|
test('todas as classes do dominio sao aceitas', () => {
|
|
for (const classification of VALID_CLASSIFICATIONS) {
|
|
const result = validateAiClassification(validRaw({ classification }));
|
|
assert.equal(result.valid, true, `classe ${classification} deveria ser valida`);
|
|
}
|
|
});
|
|
|
|
test('AI_FALLBACK nao esta no dominio de classes que a IA pode retornar', () => {
|
|
assert.ok(!VALID_CLASSIFICATIONS.includes('AI_FALLBACK'));
|
|
});
|
|
|
|
test('blocker_type/waiting_for como string "null" sao normalizados para null de verdade', () => {
|
|
const result = validateAiClassification(validRaw({ blocker_type: 'null', waiting_for: 'None' }));
|
|
assert.equal(result.valid, true);
|
|
assert.equal(result.data.blocker_type, null);
|
|
assert.equal(result.data.waiting_for, null);
|
|
});
|
|
|
|
test('blocker_type/waiting_for como "n/a" ou string vazia tambem viram null', () => {
|
|
const result = validateAiClassification(validRaw({ blocker_type: 'N/A', waiting_for: '' }));
|
|
assert.equal(result.data.blocker_type, null);
|
|
assert.equal(result.data.waiting_for, null);
|
|
});
|
|
|
|
test('blocker_type/waiting_for com valor real nao sao afetados pela normalizacao', () => {
|
|
const result = validateAiClassification(validRaw({ blocker_type: 'fornecedor', waiting_for: 'Patricia' }));
|
|
assert.equal(result.data.blocker_type, 'fornecedor');
|
|
assert.equal(result.data.waiting_for, 'Patricia');
|
|
});
|
|
|
|
test('AI_CLASSIFIER_VERSION esta definida e e carimbada em toda classificacao valida', () => {
|
|
assert.equal(typeof AI_CLASSIFIER_VERSION, 'number');
|
|
const result = validateAiClassification(validRaw({}));
|
|
assert.equal(result.data.classifier_version, AI_CLASSIFIER_VERSION);
|
|
});
|
|
|
|
test('tecnico interno (aparece em TECNICO do chamado) nunca vira WAITING_VENDOR -- missao secao 6', () => {
|
|
const ticket = { tecnico_atribuido: 'Rafael Brito' };
|
|
const result = validateAiClassification(
|
|
validRaw({ classification: 'WAITING_VENDOR', waiting_for: 'Rafael Brito', actionable_today: false }),
|
|
ticket,
|
|
);
|
|
assert.equal(result.valid, false);
|
|
assert.ok(result.errors.some((e) => e.includes('tecnico interno')));
|
|
});
|
|
|
|
test('WAITING_VENDOR com fornecedor externo de verdade (nao aparece em TECNICO) continua valido', () => {
|
|
const ticket = { tecnico_atribuido: 'Rafael Brito' };
|
|
const result = validateAiClassification(
|
|
validRaw({ classification: 'WAITING_VENDOR', waiting_for: 'fornecimento de baterias', actionable_today: false }),
|
|
ticket,
|
|
);
|
|
assert.equal(result.valid, true);
|
|
});
|
|
|
|
test('WAITING_VENDOR sem ticket informado (uso legado/sem contexto) nao quebra a validacao', () => {
|
|
const result = validateAiClassification(
|
|
validRaw({ classification: 'WAITING_VENDOR', waiting_for: 'fornecedor XPTO', actionable_today: false }),
|
|
);
|
|
assert.equal(result.valid, true);
|
|
});
|
|
|
|
test('next_action generico ("Revisar chamado") e rejeitado para ACTIONABLE_NOW -- missao secao 9', () => {
|
|
const result = validateAiClassification(validRaw({ classification: 'ACTIONABLE_NOW', next_action: 'Revisar chamado' }));
|
|
assert.equal(result.valid, false);
|
|
assert.ok(result.errors.some((e) => e.includes('generico')));
|
|
});
|
|
|
|
test('next_action generico ("Acompanhar") e rejeitado para UNASSIGNED_ACTIONABLE', () => {
|
|
const result = validateAiClassification(validRaw({ classification: 'UNASSIGNED_ACTIONABLE', next_action: 'Acompanhar', actionable_today: true }));
|
|
assert.equal(result.valid, false);
|
|
});
|
|
|
|
test('next_action concreto ("Realizar inventario das maquinas") passa para ACTIONABLE_NOW', () => {
|
|
const result = validateAiClassification(validRaw({ classification: 'ACTIONABLE_NOW', next_action: 'Realizar inventário das máquinas' }));
|
|
assert.equal(result.valid, true);
|
|
});
|
|
|
|
test('next_action curto tipo "aguardar resposta" e permitido em classes WAITING_* (nao exige verbo de acao do suporte)', () => {
|
|
const result = validateAiClassification(validRaw({ classification: 'WAITING_REQUESTER', next_action: 'Aguardar resposta do cliente', actionable_today: false }));
|
|
assert.equal(result.valid, true);
|
|
});
|