Implements the actual send branch: Selecionar Top N -> Montar Mensagem ->
Guard de Envio -> Slack real -> registrar resultado (only after
confirmed success/failure) -- previously simulated/absent.
logic/slack.js (new): shouldSendByConfig (SEND_ENABLED gate, defaults
false), computeMessageHash (djb2Hash of the exact message text, reused
from logic/hash.js), alreadySentSuccessfully (idempotency check: only a
prior status='success' record for the same report_date+run_type+
message_hash blocks a resend -- a prior 'failed' record does not, so
retries after a real failure aren't stuck), evaluateSendGuard (single
auditable decision combining both), buildEnvioDigestRecord.
logic/slack.test.js: 13 tests covering all of the above, explicitly
labeled against the mission's required tests #13-#16.
New node drivers:
- guard-envio-slack.node.js: reads the digest + recent envio records
(fetched by report_date), computes the send decision.
- Slack node itself (n8n-nodes-base.slack, native, not a raw webhook):
reuses the real "Slack account" credential (slackApi) and
$vars.SLACK_CHANNEL_TECNICO channel variable already used by this
org's own "Notificacao de Erros Globais" workflow on the same n8n
instance -- V1's own Slack webhook URL was never actually deployed
(its Config value is literally "SEU/WEBHOOK/AQUI", same class of
placeholder as the old GLPI URL from the prior cycle), so this reuses
the one REAL, credentialed Slack mechanism that exists in this
environment rather than inventing a new destination. onError:
continueErrorOutput splits success/failure into two branches.
- registrar-envio-sucesso.node.js / registrar-envio-falha.node.js: build
the success/failure record; only the success path continues to the
existing per-ticket send-counter logic (rewired below).
- lancar-erro-envio.node.js: after the failure record is written,
explicitly throws so the n8n execution shows status=error (never
silently swallow a send failure).
- pular-envio.node.js: terminal no-op for the "should not send" branch
(SEND_ENABLED=false or already sent today), for observability only.
n8n/nodes/prepare-envio-record.node.js: rewired to read the Top10
selection by name ($('Code - Selecionar Top 10').all()) instead of
$input, since it now runs downstream of the Slack-success registration,
not directly off Selecionar Top10 -- registering per-ticket send counts
before Slack ever confirmed anything was the exact "don't register
before confirmation" bug the mission called out.
logic/message.test.js: added a full-Top10 message-length regression test
(mission requirement: message stays short, no leaked JSON/score/evidence).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
59 lines
2.1 KiB
JavaScript
59 lines
2.1 KiB
JavaScript
const { djb2Hash } = require('./hash');
|
|
|
|
// Hash estavel do texto exato que seria enviado -- usado como parte da chave de
|
|
// idempotencia (junto com report_date/run_type). Duas mensagens com o mesmo conteudo no
|
|
// mesmo dia nunca devem gerar dois envios reais.
|
|
function computeMessageHash(text) {
|
|
return djb2Hash(String(text || ''));
|
|
}
|
|
|
|
// SEND_ENABLED e o unico gate de "isso pode realmente sair pro Slack" -- nunca depende de
|
|
// editar codigo (missao "finalizacao para producao", secao 22).
|
|
function shouldSendByConfig(config) {
|
|
return Boolean(config && config.sendEnabled);
|
|
}
|
|
|
|
// Idempotencia: so conta como "ja enviado" um registro com status 'success' para a MESMA
|
|
// data + tipo de execucao + hash de mensagem. Um retry apos falha (status 'failed') nao
|
|
// bloqueia um novo envio -- so um sucesso anterior bloqueia.
|
|
function alreadySentSuccessfully(existingRecords, { reportDate, runType, messageHash }) {
|
|
return (existingRecords || []).some((record) => (
|
|
record
|
|
&& record.status === 'success'
|
|
&& record.report_date === reportDate
|
|
&& record.run_type === runType
|
|
&& record.message_hash === messageHash
|
|
));
|
|
}
|
|
|
|
// Decisao unica de "devo mandar pro Slack agora" -- centraliza os dois motivos possiveis de
|
|
// NAO enviar (SEND_ENABLED=false, ou ja enviado com sucesso hoje) num so lugar auditavel.
|
|
function evaluateSendGuard({ config, existingRecords, reportDate, runType, messageHash }) {
|
|
if (!shouldSendByConfig(config)) {
|
|
return { shouldSend: false, reason: 'send_disabled' };
|
|
}
|
|
if (alreadySentSuccessfully(existingRecords, { reportDate, runType, messageHash })) {
|
|
return { shouldSend: false, reason: 'already_sent' };
|
|
}
|
|
return { shouldSend: true, reason: 'ok' };
|
|
}
|
|
|
|
function buildEnvioDigestRecord({ reportDate, runType, messageHash, sentAt, status, errorDetail }) {
|
|
return {
|
|
report_date: reportDate,
|
|
run_type: runType,
|
|
message_hash: messageHash,
|
|
sent_at: sentAt,
|
|
status,
|
|
error_detail: errorDetail || null,
|
|
};
|
|
}
|
|
|
|
module.exports = {
|
|
computeMessageHash,
|
|
shouldSendByConfig,
|
|
alreadySentSuccessfully,
|
|
evaluateSendGuard,
|
|
buildEnvioDigestRecord,
|
|
};
|