gustavosantos/MIKROTIK-RMM
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

feat: non-blocking bulk-add, CORS hardening, credential preset access control (#31)

Browse Source 
* devices: hide discovered neighbors that are already managed

Discovered Devices showed every unresolved MikroTik neighbor, even when
the neighbor was obviously the same device a managed node is reporting
through a different link / MAC / alias. Since we already know every
managed device interface MAC, primary IP, and system identity, we can
flag those rows.

- /api/devices/discovered now annotates each row with duplicate_of_device_id
  and duplicate_of_device_name when the neighbor matches a managed device
  by interface MAC, primary IP, or system identity.
- Add a Hide duplicates of managed devices toggle (default on) above the
  table, with a count of how many matches were found. When enabled, the
  list hides matched rows; when disabled, matches stay visible but are
  dimmed and tagged Already managed so the origin is clear.
- Suppress the Add to Manager action for rows that are already a
  managed device, since adding them would create a second record for the
  same hardware.

Co-authored-by: Denis <denis-ev@users.noreply.github.com>

* devices: safer duplicate handling, try-all safeguards, and timezone/firmware fixes

Co-authored-by: Denis <denis-ev@users.noreply.github.com>

* Non-blocking follow-ups: parsePort util, tests, bulk-add queue, preset rate limit

Co-authored-by: Denis <denis-ev@users.noreply.github.com>

* fix(security): tighten CORS, Redis rate limits, and preset access controls

Require explicit CORS origins in production, align Socket.IO CORS with HTTP,
default Docker Compose to local HTTPS origins, and remove the in-memory
mutation limiter in favor of Redis. Also add operator-use flags for credential
presets in the UI and harden bulk-add job access and client error messages.

Co-authored-by: Denis <denis-ev@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
This commit is contained in:
Denis
2026-04-21 19:54:35 -07:00
committed by GitHub
co-authored by Cursor Agent
parent 87a6d9161a
commit a12f52ebc7
28 changed files with 1912 additions and 252 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/routes/devices.ts
+95 -172
View File
@@ -1,4 +1,5 @@
import { Router, Request, Response } from 'express';
import { randomUUID } from 'crypto';
import { query, queryOne } from '../config/database';
import { requireAuth, requireWrite } from '../middleware/auth';
import { encrypt, decrypt } from '../utils/crypto';
@@ -6,11 +7,17 @@ import { RouterOSClient } from '../services/mikrotik/RouterOSClient';
import { DeviceCollector, DeviceRow } from '../services/mikrotik/DeviceCollector';
import { PollerService } from '../services/PollerService';
import type { CredentialPresetRow } from './credentialPresets';
import { createDeviceFromBody, type CreateDeviceInput, type CreateDeviceContext } from '../services/deviceCreation';
import { parsePort } from '../utils/parsePort';
import { safeConnectionError } from '../utils/safeClientError';
import { redis } from '../config/redis';
import { enqueueBulkAddJob, getBulkAddJobState } from '../services/DeviceBulkAddWorker';
// Resolve a credential preset id into decrypted credentials. Returns null if
// no id was provided; throws a readable error if the id is invalid.
async function loadCredentialPreset(
id: number | null | undefined
id: number | null | undefined,
ctx?: CreateDeviceContext
): Promise<{
api_username: string;
api_password: string;
@@ -25,6 +32,12 @@ async function loadCredentialPreset(
[id]
);
if (!preset) throw new Error(`Credential preset ${id} not found`);
const allowOp = preset.allow_operator_use !== false;
if (ctx?.requestingUserRole === 'operator' && !allowOp) {
const err = new Error('This credential preset is restricted to administrators');
(err as Error & { statusCode?: number }).statusCode = 403;
throw err;
}
return {
api_username: preset.api_username,
api_password: decrypt(preset.api_password_encrypted),
@@ -165,165 +178,71 @@ router.get('/discovered', async (_req: Request, res: Response) => {
// POST /api/devices
router.post('/', requireWrite, async (req: Request, res: Response) => {
const {
name, ip_address, device_type = 'router', notes,
credential_preset_id,
} = req.body as { name?: string; ip_address?: string; device_type?: string; notes?: string; credential_preset_id?: number | null };
const result = await createDeviceFromBody(req.body, pollerService, {
requestingUserRole: req.user?.role,
});
return res.status(result.status).json(result.body);
});
// If a preset is supplied, its credentials win over anything else in the
// body — the client just needs to say "use preset 3". Anything the body
// also sends (like ssh_username) is ignored in favor of preset values, so
// "deploying" a preset always produces a consistent device record.
let preset: Awaited<ReturnType<typeof loadCredentialPreset>> = null;
try {
preset = await loadCredentialPreset(credential_preset_id ?? null);
} catch (err) {
return res.status(400).json({ error: (err as Error).message });
const BULK_ADD_META_TTL_SEC = 86400;
// POST /api/devices/bulk-add/jobs — enqueue Try-All style adds (survives tab close)
router.post('/bulk-add/jobs', requireWrite, async (req: Request, res: Response) => {
const { items } = req.body as { items?: unknown };
if (!Array.isArray(items) || items.length === 0) {
return res.status(400).json({ error: 'items must be a non-empty array' });
}
const api_username: string | undefined = preset?.api_username ?? req.body.api_username;
const api_password: string | undefined = preset?.api_password ?? req.body.api_password;
const parsePort = (v: unknown, fallback: number): number => {
if (v == null || v === '') return fallback;
const n = typeof v === 'number' ? v : parseInt(String(v), 10);
return Number.isFinite(n) ? n : fallback;
};
const api_port: number = preset?.api_port ?? parsePort(req.body.api_port, 8728);
const ssh_username: string | null = preset ? preset.ssh_username : (req.body.ssh_username ?? null);
const ssh_password: string | null = preset ? preset.ssh_password : (req.body.ssh_password ?? null);
const ssh_port: number = preset?.ssh_port ?? parsePort(req.body.ssh_port, 22);
const combineWithDeviceId =
typeof req.body.combine_with_device_id === 'number' ? req.body.combine_with_device_id : null;
const forceReplaceBySerial = req.body.force_replace_existing_by_serial === true;
if (!name || !ip_address || !api_username || !api_password) {
return res.status(400).json({ error: 'name, ip_address, api_username, api_password are required' });
if (items.length > 500) {
return res.status(400).json({ error: 'items array exceeds maximum of 500' });
}
// Test connection and detect hardware serial before saving
const testClient = new RouterOSClient(ip_address, api_port, api_username, api_password, 10_000);
let detectedSerial: string | null = null;
try {
await testClient.connect();
const rb = await testClient.execute('/system/routerboard/print').catch(() => [] as Record<string, string>[]);
detectedSerial = (rb[0]?.['serial-number'] || '').trim() || null;
} catch (err) {
return res.status(422).json({
error: `Cannot connect to device: ${(err as Error).message}`,
});
} finally {
testClient.disconnect();
}
if (detectedSerial) {
const existingBySerial = await queryOne<{
id: number;
name: string;
ip_address: string;
serial_number: string;
}>(
`SELECT id, name, ip_address, serial_number
FROM devices
WHERE serial_number = $1`,
[detectedSerial]
);
if (existingBySerial) {
const shouldCombine =
combineWithDeviceId != null && combineWithDeviceId === existingBySerial.id;
if (!shouldCombine && !forceReplaceBySerial) {
return res.status(409).json({
error: 'duplicate_serial',
code: 'duplicate_serial',
existing_device: existingBySerial,
candidate: {
serial_number: detectedSerial,
identity: name,
ip_address,
},
});
}
const encryptedPass = encrypt(api_password);
const encryptedSshPass = ssh_password ? encrypt(ssh_password) : null;
await query(
`UPDATE devices SET
name=COALESCE($1,name),
ip_address=$2,
api_port=$3,
api_username=$4,
api_password_encrypted=$5,
ssh_port=$6,
ssh_username=COALESCE($7,ssh_username),
ssh_password_encrypted=COALESCE($8,ssh_password_encrypted),
device_type=COALESCE($9,device_type),
notes=COALESCE($10,notes),
updated_at=NOW()
WHERE id = $11`,
[
name,
ip_address,
api_port,
api_username,
encryptedPass,
ssh_port,
ssh_username,
encryptedSshPass,
device_type,
notes || null,
existingBySerial.id,
]
);
if (pollerService) {
await pollerService.scheduleDeviceSync(existingBySerial.id, 'full');
}
const updatedExisting = await queryOne(
`SELECT id, name, ip_address, api_port, api_username, model, serial_number,
firmware_version, ros_version, device_type, status, last_seen, notes, created_at
FROM devices WHERE id = $1`,
[existingBySerial.id]
);
if (!updatedExisting) {
return res.status(500).json({
error: 'Duplicate merge succeeded but device row could not be reloaded',
device_id: existingBySerial.id,
});
}
return res.status(200).json({
...updatedExisting,
merged_from_duplicate: true,
});
}
}
const encryptedPass = encrypt(api_password);
const encryptedSshPass = ssh_password ? encrypt(ssh_password) : null;
const rows = await query<{ id: number }>(
`INSERT INTO devices (name, ip_address, api_port, api_username, api_password_encrypted,
ssh_port, ssh_username, ssh_password_encrypted, device_type, notes, status)
VALUES ($1,$2,$3,$4,$5,$6,$7,$8,$9,$10,'unknown') RETURNING id`,
[name, ip_address, api_port, api_username, encryptedPass,
ssh_port, ssh_username || null, encryptedSshPass, device_type, notes || null]
const jobId = randomUUID();
const ownerUserId = req.user!.userId;
await redis.set(
`device-bulk-add:${jobId}:meta`,
JSON.stringify({
status: 'queued',
total: items.length,
processed: 0,
owner_user_id: ownerUserId,
created_at: new Date().toISOString(),
}),
'EX',
BULK_ADD_META_TTL_SEC
);
await redis.set(`device-bulk-add:${jobId}:results`, '[]', 'EX', BULK_ADD_META_TTL_SEC);
await enqueueBulkAddJob(jobId, items as CreateDeviceInput[]);
return res.status(202).json({ job_id: jobId, total: items.length });
});
const newId = rows[0].id;
// Trigger full sync in background
if (pollerService) {
await pollerService.scheduleDeviceSync(newId, 'full');
// POST /api/devices/bulk-add/jobs/:jobId/cancel — request cooperative cancel
router.post('/bulk-add/jobs/:jobId/cancel', requireWrite, async (req: Request, res: Response) => {
const state = await getBulkAddJobState(req.params.jobId);
if (!state.found) {
return res.status(404).json({ error: 'Job not found or expired' });
}
const ownerId = state.meta.owner_user_id;
if (typeof ownerId !== 'number' || ownerId !== req.user!.userId) {
return res.status(403).json({ error: 'Forbidden' });
}
await redis.set(`device-bulk-add:${req.params.jobId}:cancel`, '1', 'EX', BULK_ADD_META_TTL_SEC);
return res.json({ message: 'Cancel requested' });
});
const device = await queryOne(
`SELECT id, name, ip_address, api_port, api_username, model, serial_number,
firmware_version, ros_version, device_type, status, last_seen, notes, created_at
FROM devices WHERE id = $1`,
[newId]
);
return res.status(201).json(device);
// GET /api/devices/bulk-add/jobs/:jobId — poll job status and incremental results
router.get('/bulk-add/jobs/:jobId', requireWrite, async (req: Request, res: Response) => {
const state = await getBulkAddJobState(req.params.jobId);
if (!state.found) {
return res.status(404).json({ error: 'Job not found or expired' });
}
const ownerId = state.meta.owner_user_id;
if (typeof ownerId !== 'number' || ownerId !== req.user!.userId) {
return res.status(403).json({ error: 'Forbidden' });
}
return res.json({
job_id: req.params.jobId,
...state.meta,
results: state.results,
});
});
// GET /api/devices/:id
@@ -392,35 +311,39 @@ router.put('/:id', requireWrite, async (req: Request, res: Response) => {
credential_preset_id?: number | null;
};
let preset: Awaited<ReturnType<typeof loadCredentialPreset>> = null;
try {
preset = await loadCredentialPreset(credential_preset_id ?? null);
} catch (err) {
return res.status(400).json({ error: (err as Error).message });
}
// When a preset is applied, its values take precedence over anything else
// in the body so "apply preset" has a single unambiguous meaning.
const api_port = preset?.api_port ?? req.body.api_port;
const api_username = preset?.api_username ?? req.body.api_username;
const api_password = preset?.api_password ?? req.body.api_password;
const ssh_port = preset?.ssh_port ?? req.body.ssh_port;
const ssh_username = preset ? preset.ssh_username : req.body.ssh_username;
const ssh_password = preset ? preset.ssh_password : req.body.ssh_password;
const existing = await queryOne<{
id: number;
ip_address: string;
api_port: number;
api_username: string;
api_password_encrypted: string;
ssh_port: number | null;
}>(
`SELECT id, ip_address, api_port, api_username, api_password_encrypted
`SELECT id, ip_address, api_port, api_username, api_password_encrypted, ssh_port
FROM devices WHERE id = $1`,
[req.params.id]
);
if (!existing) return res.status(404).json({ error: 'Device not found' });
let preset: Awaited<ReturnType<typeof loadCredentialPreset>> = null;
try {
preset = await loadCredentialPreset(credential_preset_id ?? null, {
requestingUserRole: req.user?.role,
});
} catch (err) {
const status = (err as Error & { statusCode?: number }).statusCode ?? 400;
return res.status(status).json({ error: (err as Error).message });
}
// When a preset is applied, its values take precedence over anything else
// in the body so "apply preset" has a single unambiguous meaning.
const api_port = preset?.api_port ?? parsePort(req.body.api_port, existing.api_port);
const api_username = preset?.api_username ?? req.body.api_username;
const api_password = preset?.api_password ?? req.body.api_password;
const ssh_port = preset?.ssh_port ?? parsePort(req.body.ssh_port, existing.ssh_port ?? 22);
const ssh_username = preset ? preset.ssh_username : req.body.ssh_username;
const ssh_password = preset ? preset.ssh_password : req.body.ssh_password;
// If the user is changing the IP (or port / username / password), verify the
// RouterOS API is still reachable with the new values before persisting —
// otherwise we could silently brick the device record.
@@ -430,7 +353,7 @@ router.put('/:id', requireWrite, async (req: Request, res: Response) => {
const presetReplacesApiCreds = !!preset;
if (ipChanged || portChanged || userChanged || api_password || presetReplacesApiCreds) {
const testIp = ip_address ?? existing.ip_address;
const testPort = (typeof api_port === 'number' ? api_port : undefined) ?? existing.api_port;
const testPort = api_port;
const testUser = api_username ?? existing.api_username;
const testPass = api_password ? api_password : decrypt(existing.api_password_encrypted);
const testClient = new RouterOSClient(testIp, testPort, testUser, testPass, 10_000);
@@ -439,7 +362,7 @@ router.put('/:id', requireWrite, async (req: Request, res: Response) => {
testClient.disconnect();
} catch (err) {
return res.status(422).json({
error: `Cannot connect to device with new settings: ${(err as Error).message}`,
error: safeConnectionError('PUT /devices/:id', err),
});
}
}