feat: TECHNICAL_PLACEHOLDER (NCM 00000000) is replaceable by the product enrichment; real values preserved; Agent 1.3.4

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

agent/tests/test_enrichment.py

@@ -45,7 +45,7 @@ class Hub:
         for f in list(fields):
             if f in self.overridden.get(payload["product_code"], set()):
                 fields[f] = {"status": "HUMAN_OVERRIDDEN", "value": None}
-            elif payload["current"].get(f):
+            elif payload["current"].get(f) and not E.is_placeholder(f, payload["current"].get(f)):
                 fields[f] = {"status": "ALREADY_SET", "value": None}
         return {"state": self.state, "fields": fields, "dataset_versions": {"NCM": {"sha256": "abc"}}}
 
@@ -230,3 +230,68 @@ def test_products_created_while_inactive_are_not_new_when_reactivated(env):
     add(db, "W2")
     now[0] += 5
     assert worker.step() == ["W2"]
+
+
+# ---- TECHNICAL_PLACEHOLDER (the SGV refuses a product without NCM: operators type 00000000) ---------------------------------------------------
+def add_with_ncm(db, code, ncm, name="COCA-COLA ORIGINAL LATA 350 ML"):
+    db.execute("INSERT INTO C000025(CODIGO,PRODUTO,GTIN,CLASSIFICACAO_FISCAL,OTHER) VALUES(?,?,?,?,?)", (code, name, "7891000100103", ncm, "keep"))
+    db.commit()
+
+
+def test_placeholder_parity_with_the_hub():
+    sys.path.insert(0, str(ROOT))
+    from central.app.enrichment import placeholders as hub
+    assert {k: set(v) for k, v in E.PLACEHOLDERS.items()} == {k: set(v) for k, v in hub.PRODUCT_ENRICHMENT_PLACEHOLDERS.items()}
+    for value in ("00000000", "0000.00.00", " 00000000 ", "22021000", "99999999", "0", "SEM NCM", "", None):
+        assert E.is_placeholder("CLASSIFICACAO_FISCAL", value) == hub.is_placeholder("CLASSIFICACAO_FISCAL", value), value
+    assert not E.is_placeholder("CEST", "0000000") and not E.is_placeholder("IPI", 0)
+
+
+def test_placeholder_ncm_is_replaced_dry_run_first_then_enabled_and_second_run_is_zero(env):
+    db, hub, store, worker, now, _ = env
+    hub.features = {"features_configured": True, "enrichment_mode": "DRY_RUN"}
+    worker._features_at = -999
+    worker.step()                                                    # baseline
+    add_with_ncm(db, "P1", "00000000")
+    now[0] += 5
+    worker.step()
+    assert row(db, "P1")[0] == "00000000" and hub.reports[-1]["fields"][0]["outcome"] == "DRY_RUN"       # DRY_RUN: detected, zero writes
+    assert hub.resolve_calls[-1]["current"]["CLASSIFICACAO_FISCAL"] == "00000000"
+    hub.features = dict(ENABLED)
+    worker._features_at = -999
+    worker._auth_cache = (None, 0.0)
+    add_with_ncm(db, "P2", "00000000")
+    now[0] += 5
+    worker.step()
+    assert row(db, "P2") == ("22021000", "0300700", 0.0, "keep")
+    first = [f for f in hub.reports[-1]["fields"] if f["field"] == "CLASSIFICACAO_FISCAL"][0]
+    assert first["outcome"] == "APPLIED" and first["old"] == "00000000"
+    before = db.total_changes
+    now[0] += 5
+    worker.step()
+    now[0] += 60
+    worker.step()
+    assert db.total_changes == before                                # second run: 0 writes
+
+
+def test_real_or_unlisted_ncm_is_never_replaced(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    for code, ncm in (("R1", "22021000"), ("R2", "99999999"), ("R3", "0"), ("R4", "SEM NCM"), ("R5", "19059090")):
+        add_with_ncm(db, code, ncm)
+    now[0] += 5
+    worker.step()
+    for code, ncm in (("R1", "22021000"), ("R2", "99999999"), ("R3", "0"), ("R4", "SEM NCM"), ("R5", "19059090")):
+        assert row(db, code)[0] == ncm, code                          # EXISTING_REAL_VALUE_PRESERVED, even if the KB says otherwise
+
+
+def test_write_field_guards_the_placeholder_swap():
+    db = sqlite3.connect(":memory:")
+    db.execute("CREATE TABLE C000025(CODIGO TEXT, CLASSIFICACAO_FISCAL TEXT)")
+    db.executemany("INSERT INTO C000025 VALUES(?,?)", [("a", "00000000"), ("b", "22021000"), ("c", None), ("d", "0000.00.00")])
+    db.commit()
+    assert E.write_field(Conn(db), "a", "CLASSIFICACAO_FISCAL", "19059090")["outcome"] == "APPLIED"
+    assert E.write_field(Conn(db), "b", "CLASSIFICACAO_FISCAL", "19059090")["reason"] == "VALUE_ALREADY_SET_NEVER_OVERWRITTEN"
+    assert E.write_field(Conn(db), "c", "CLASSIFICACAO_FISCAL", "19059090")["outcome"] == "APPLIED"
+    assert E.write_field(Conn(db), "d", "CLASSIFICACAO_FISCAL", "19059090")["outcome"] == "APPLIED"
+    assert [r[0] for r in db.execute("SELECT CLASSIFICACAO_FISCAL FROM C000025 ORDER BY CODIGO")] == ["19059090", "22021000", "19059090", "19059090"]