fix: close remaining task 2 review findings

This commit is contained in:
gti
2026-09-22 18:23:38 -03:00
parent 041257d254
commit 2ee271ca80
5 changed files with 73 additions and 8 deletions
@@ -280,3 +280,33 @@ def test_worst_coverage_sort_uses_the_displayed_derived_percentage():
assert result["items"][0]["installation_id"] == second.installation_id
assert result["items"][0]["fiscal_completion_percent"] == 20
assert first.installation_id != second.installation_id
def test_worst_coverage_sort_cannot_disagree_with_one_decimal_display():
session_factory = setup_db()
with session_factory() as session:
_, _, first, first_snapshot = _installation(session, 1, coverage=0)
_, _, second, second_snapshot = _installation(session, 2, coverage=0)
first_snapshot.total_products = 79
first_snapshot.fiscally_complete = 5
second_snapshot.total_products = 16
second_snapshot.fiscally_complete = 1
session.commit()
result = list_installations(session, sort="worst_coverage", page_size=10, now=NOW)
displayed = [item["fiscal_completion_percent"] for item in result["items"]]
assert displayed == sorted(displayed)
assert displayed == [6.3, 6.3]
assert {item["installation_id"] for item in result["items"]} == {first.installation_id, second.installation_id}
def test_lowercase_required_blocker_field_reaches_attention_candidates():
session_factory = setup_db()
with session_factory() as session:
tenant, _, installation, _ = _installation(session, 1)
blocker = _blocker(session, tenant, product="LOWER", field="cfop", index=120, installation_id=installation.id)
attention = dashboard_summary(session, now=NOW)["attention_items"]
assert any(item["link"] == f"/blockers/{blocker.id}" for item in attention)