feat: visible per-product enrichment status, flagged re-evaluation (panel/Reprocessar/Sincronizar/KB decision), operator NCM decision, deterministic name-only match, stale-write guard; 1.3.5

agent/tests/test_enrichment.py

@@ -49,6 +49,10 @@ class Hub:
                 fields[f] = {"status": "ALREADY_SET", "value": None}
         return {"state": self.state, "fields": fields, "dataset_versions": {"NCM": {"sha256": "abc"}}}
 
+    def pending_enrichment(self):
+        codes, self.flagged = list(getattr(self, "flagged", [])), []
+        return codes
+
     def report_enrichment(self, payload):
         self.reports.append(payload)
         for item in payload["fields"]:
@@ -295,3 +299,84 @@ def test_write_field_guards_the_placeholder_swap():
     assert E.write_field(Conn(db), "c", "CLASSIFICACAO_FISCAL", "19059090")["outcome"] == "APPLIED"
     assert E.write_field(Conn(db), "d", "CLASSIFICACAO_FISCAL", "19059090")["outcome"] == "APPLIED"
     assert [r[0] for r in db.execute("SELECT CLASSIFICACAO_FISCAL FROM C000025 ORDER BY CODIGO")] == ["19059090", "22021000", "19059090", "19059090"]
+
+
+# ---- restart / race / multiple products / stale guard / reevaluation / provenance --------------------------------------------------------------
+def make_worker(db, hub, store, now):
+    return E.EnrichmentWorker(hub=hub, store=store, read_conn=lambda: Conn(db), write_conn=lambda: Conn(db), create_reprocess=lambda codes: None, clock=lambda: now[0], sleep=lambda s: None)
+
+
+def test_product_created_while_agent_is_down_is_found_after_restart(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    add(db, "D1")                                                      # created while the Agent is stopped / restarting
+    worker2 = make_worker(db, hub, store, now)                         # new process, same persisted state
+    now[0] += 5
+    assert worker2.step() == ["D1"] and row(db, "D1")[0] == "22021000"
+
+
+def test_many_products_between_polls_and_a_deleted_one(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    for i in range(5):
+        add(db, f"M{i}")
+    db.execute("DELETE FROM C000025 WHERE CODIGO='M2'")
+    db.commit()
+    add(db, "M9")
+    now[0] += 5
+    done = worker.step()
+    assert sorted(done) == ["M0", "M1", "M3", "M4", "M9"] and all(row(db, c)[0] == "22021000" for c in done)
+
+
+def test_reevaluation_flagged_by_the_hub_retries_an_unresolved_product(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    hub.decisions = {}                                                  # first attempt: nothing known yet
+    add(db, "U1")
+    now[0] += 5
+    worker.step()
+    assert row(db, "U1")[0] is None and store.get("U1")["state"] == "DONE"
+    hub.decisions = dict(DECISIONS)                                      # new evidence (KB decision) + 'Reavaliar'/'Reprocessar'
+    hub.flagged = ["U1"]
+    now[0] += 30
+    assert "U1" in worker.step() and row(db, "U1")[0] == "22021000"
+    now[0] += 30
+    before = db.total_changes
+    worker.step()
+    assert db.total_changes == before
+
+
+def test_stale_write_is_refused_when_a_person_changed_the_value_after_the_decision(env):
+    db = sqlite3.connect(":memory:")
+    db.execute("CREATE TABLE C000025(CODIGO TEXT, CLASSIFICACAO_FISCAL TEXT)")
+    db.execute("INSERT INTO C000025 VALUES('a','19059090')")
+    db.execute("INSERT INTO C000025 VALUES('b','00000000')")
+    db.commit()
+    assert E.write_field(Conn(db), "a", "CLASSIFICACAO_FISCAL", "22021000", observed="00000000", guard_observed=True)["reason"] == "STALE_CONFLICT"
+    assert E.write_field(Conn(db), "b", "CLASSIFICACAO_FISCAL", "22021000", observed="00000000", guard_observed=True)["outcome"] == "APPLIED"
+
+
+def test_placeholder_after_a_human_override_is_not_filled_again(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    add_with_ncm(db, "HP1", "00000000")                                  # born with the placeholder: eligible
+    now[0] += 5
+    worker.step()
+    assert row(db, "HP1")[0] == "22021000"
+    db.execute("UPDATE C000025 SET CLASSIFICACAO_FISCAL='00000000' WHERE CODIGO='HP1'")   # a person puts the SAME value back: a human decision now
+    db.commit()
+    now[0] += 30
+    worker.step()
+    assert store.is_overridden("HP1", "CLASSIFICACAO_FISCAL")
+    hub.flagged = ["HP1"]
+    now[0] += 30
+    worker.step()
+    assert row(db, "HP1")[0] == "00000000"                               # provenance matters: same value, different meaning
+
+
+def test_automatic_mode_needs_no_sync_button_or_restart(env):
+    db, hub, store, worker, now, _ = env
+    worker.step()
+    add(db, "A1")
+    now[0] += 3
+    assert worker.step() == ["A1"] and row(db, "A1")[0] == "22021000"        # save -> next poll -> written